[webkit-reviews] review granted: [Bug 20818] 'instanceof' operator is slow : [Attachment 23690] use a TypeInfo bit to inline hasInfo and do the checks in a smarter order in the common case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 20818: 'instanceof' operator is slow
https://bugs.webkit.org/show_bug.cgi?id=20818

Attachment 23690: use a TypeInfo bit to inline hasInfo and do the checks in a
smarter order in the common case
https://bugs.webkit.org/attachment.cgi?id=23690&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
>From the caller's point of view, customHasInstance is still just hasInstance,
so I'm not sure it was an improvement to rename it.

Since you wrote different hasInstance code in cti_op_instanceof, there's no
need for the standardHasInstance inline function, so you could have also just
left it  alone.

You could have named the flag OverridesHasInstance.

This:

    valueCell->structureID()->typeInfo().type() != ObjectType

Is this same as !isObject(). Why did you write it the longer way?

r=me with or without changes