[webkit-reviews] review denied: [Bug 21009] [PATCH] webkit_web_view_execute_script returning an execution result value : [Attachment 23675] webkit_web_view_execute_script returning result of execution

[bugzilla-daemon at webkit.org]

Alp Toker <alp at nuanti.com> has denied Anton Nonko <anton.nonko at gmail.com>'s
request for review:
Bug 21009: [PATCH] webkit_web_view_execute_script returning an execution result
value
https://bugs.webkit.org/show_bug.cgi?id=21009

Attachment 23675: webkit_web_view_execute_script returning result of execution
https://bugs.webkit.org/attachment.cgi?id=23675&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
Antonin,

webkit_web_view_execute_script() was intended for very simple uses only. For
anyone needing return values, it's probably more appropriate to use the
JavaScriptCore API directly or use the gjs GObject/JavaScript bridge (developed
externally to WebKit at the moment).

Even if we have to add a new convenience function like this, I'd prefer not to
change webkit_web_view_execute_script() but add a new function clearly named
for the purpose.

If you're interested in further JavaScript integration in the API, you could
investigate what it would take to get gjs merged into WebKit so we can do more
integration.

Marking r- because at the very least this will need a new function (along with
documentation). Would be interested to hear the thoughts of others on this.