[webkit-reviews] review denied: [Bug 20994] HTMLVideoElement width and height attributes are now unsigned : [Attachment 23656] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 22 14:17:31 PDT 2008


Sam Weinig <sam at webkit.org> has denied Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 20994: HTMLVideoElement width and height attributes are now unsigned
https://bugs.webkit.org/show_bug.cgi?id=20994

Attachment 23656: Revised patch
https://bugs.webkit.org/attachment.cgi?id=23656&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+    unsigned w = getAttribute(widthAttr).toInt(&ok);

+    unsigned h = getAttribute(heightAttr).toInt(&ok);

These need to use toUInt().


More information about the webkit-reviews mailing list