[webkit-reviews] review granted: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 23484] Improved possible fix to bug 20534

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Glenn Wilson <gwilson at google.com>'s
request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 23484: Improved possible fix to bug 20534
https://bugs.webkit.org/attachment.cgi?id=23484&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  Glenn and I talked about possibly having DumpRenderTree maintain
the state of whether the preferences were "overridden" instead of extending the
preferences object to know this.

DRT doesn't currently have a clean way for layout test controller to record
this information, and there is some (small) possibility that some other client
of preferences might want to be able to check if any preferences have been
changed from the defaults or to reset to the defaults in an efficient way, so
he's left that added functionality in the patch.

There were a couple c-style casts which could have been static_cast, but not
enough to justify another round of patch.