[webkit-reviews] review granted: [Bug 20982] Speed up the apply method of functions by special-casing array and 'arguments' objects : [Attachment 23643] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 22 11:41:47 PDT 2008


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 20982: Speed up the apply method of functions by special-casing array and
'arguments' objects
https://bugs.webkit.org/show_bug.cgi?id=20982

Attachment 23643: patch
https://bugs.webkit.org/attachment.cgi?id=23643&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
If speed really matters for Arguments, then we need to do various checks
outside the loops rather than inside, so for example:

    - We need an entirely separate loop for the Arguments case where there are
no deleted arguments.

    - The loop for the parameters should come first, then a separate loop to
handle arguments.

r=me


More information about the webkit-reviews mailing list