[webkit-reviews] review denied: [Bug 20872] Enhancing Navigation to Accessibility parent : [Attachment 23493] This patch contains only the changes to enhance the navigation to the accessibility parent.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 21 20:58:53 PDT 2008


Jon Honeycutt <jhoneycutt at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20872: Enhancing Navigation to Accessibility parent
https://bugs.webkit.org/show_bug.cgi?id=20872

Attachment 23493: This patch contains only the changes to enhance the
navigation to the accessibility parent.
https://bugs.webkit.org/attachment.cgi?id=23493&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
We prefer early return, so this would be better written as:

if (!parentObj)
    return E_FAIL;
...

The change looks good, just needs a test. r- for missing test.

Thanks for the patch, Sankar!


More information about the webkit-reviews mailing list