[webkit-reviews] review denied: [Bug 20287] [Gtk] disable plugins for gtk/directfb target : [Attachment 23620] Patch to fix this issue - includes directfb build fixes too.

[bugzilla-daemon at webkit.org]

Holger Freyther <freyther at handhelds.org> has denied Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 20287: [Gtk] disable plugins for gtk/directfb target
https://bugs.webkit.org/show_bug.cgi?id=20287

Attachment 23620: Patch to fix this issue - includes directfb build fixes too.
https://bugs.webkit.org/attachment.cgi?id=23620&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Substance:
  - Is GDK_WINDOWING_X11 really defined when building for Gtk+/X11? Is that due
a broken pc file?

  - Your patch is changing a lot more than advertised. Change the summary or
split it up.

  - We added cairo-ft for a specific reason, we have to figure out if that
reason is gone

   - Adding a random directory to cppflags is quite "dangerous", people with
broken packages could just do CPPFLAGS=-I/right/dir ./configure. Specially when
cross compiling we might pick up the wrong headers.

Style:
   - #define WTF_USE_BLA 1 is supposed to be used in a #if USE(BLA) way.


And I agree that plugins should/can currently only be build on Gtk+/X11.