[webkit-reviews] review denied: [Bug 20746] Port WebKit to Qt on Windows CE : [Attachment 23340] Fix compilation on Windows CE when using some C string functions (updated for WINCE -> WIN_CE)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20746: Port WebKit to Qt on Windows CE
https://bugs.webkit.org/show_bug.cgi?id=20746

Attachment 23340: Fix compilation on Windows CE when using some C string
functions (updated for WINCE -> WIN_CE)
https://bugs.webkit.org/attachment.cgi?id=23340&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
We prefer to use inline functions instead of macros for cases like this. Look
at the inline function for strncasecmp right below for an example of what I'm
talking about.

(If we did use macros, we'd want to use macros with argument names rather than
just doing the name of the function alone, but that's a moot point -- lets use
inline functions.)

I'm going to say review-, but I'd love to see a version of this that used
inline functions instead.