[webkit-reviews] review granted: [Bug 20973] [Qt] SVG patterns are missing : [Attachment 23629] SVGPattern

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20973: [Qt] SVG patterns are missing
https://bugs.webkit.org/show_bug.cgi?id=20973

Attachment 23629: SVGPattern
https://bugs.webkit.org/attachment.cgi?id=23629&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    PassRefPtr<Pattern> pattern;
+    pattern = Pattern::create(tile()->image(), true, true);

This is an inefficient idiom. It's more efficient to initialize on the same
line the variable is defined on. But also the local variable should be RefPtr,
not PassRefPtr. See <http://webkit.org/coding/RefPtr.html> for guidelines.

+    QBrush brush(pattern.get()->createPlatformPattern(affine));

No need for the call to get() here. You can just use the -> operator normally
with smart pointers.

r=me as-is, but I suggest making those two refinements.