[webkit-reviews] review denied: [Bug 20403] [Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript. : [Attachment 23568] move g_object_unref() and m_frame = 0 into frameLoaderDestroyed()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 20403: [Gtk] Segfault after a table with an iframe is attempted to be added
twice to DOM model with javascript.
https://bugs.webkit.org/show_bug.cgi?id=20403

Attachment 23568: move g_object_unref() and m_frame = 0 into
frameLoaderDestroyed()
https://bugs.webkit.org/attachment.cgi?id=23568&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Yes, this is exactly the right fix!

+    notImplemented();

There's no reason to add that call. It's fine for detachedFromParent4() to be
empty and no need to call notImplemented().

The change looks fine, but there's no ChangeLog nor test case, so I'm going to
say review-. Please submit a new patch with ChangeLog. If this was a platform
where layout tests were working well, I'd insist on a test case too, but I
don't think GTK is working well with regression tests yet, so I guess we're OK
without one.