[webkit-reviews] review denied: [Bug 20699] SVGPaintServer CleanUp : [Attachment 23625] SVGPaintServer cleanUp - third part

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 21 07:19:12 PDT 2008

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20699: SVGPaintServer CleanUp

Attachment 23625: SVGPaintServer cleanUp - third part

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  Except why are you adding:
 97 void SVGPaintServerSolid::renderPath(GraphicsContext*& context, const
RenderObject* path, SVGPaintTargetType type) const

That's already implemented exactly like that in SVGPaintServer, or?  Maybe
that's only for CG?

Also, it seems:

should go in setup() in the fill if-block not in renderPath(), or?

More information about the webkit-reviews mailing list