[webkit-reviews] review granted: [Bug 20820] op_stricteq is slow : [Attachment 23619] more speedups for the CTI case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 20 22:26:23 PDT 2008

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 20820: op_stricteq is slow

Attachment 23619: more speedups for the CTI case

------- Additional Comments from Darin Adler <darin at apple.com>
+	 (JSC::Machine::cti_op_stricteq): Check for pointer equality first; use
inline version
+	 of strictEqualSlowCase; remove unneeded exception check.

I don't see any "check for pointer equality first" change.

-	     r[dst] = jsBoolean(reinterpret_cast<intptr_t>(src1) ==
+	     r[dst]= jsBoolean(reinterpret_cast<intptr_t>(src1) ==

Should change this back. No reason to delete the space before that "=".

-    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 !=
JSImmediate::from(0)) & (src2 != JSImmediate::from(0)))
+    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 !=
JSImmediate::zeroImmediate()) & (src2 != JSImmediate::zeroImmediate()))

JSImmediate::from(0) doesn't get constant folded?


More information about the webkit-reviews mailing list