[webkit-reviews] review denied: [Bug 20746] Port WebKit to Qt on Windows CE : [Attachment 23466] Implemented currentThreadStackBase() on Windows CE. (updated)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 20 13:45:26 PDT 2008


Eric Seidel <eric at webkit.org> has denied Joerg Bornemann
<joerg.bornemann at trolltech.com>'s request for review:
Bug 20746: Port WebKit to Qt on Windows CE
https://bugs.webkit.org/show_bug.cgi?id=20746

Attachment 23466: Implemented currentThreadStackBase() on Windows CE. (updated)
https://bugs.webkit.org/attachment.cgi?id=23466&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please use WebKit style for your changes.
http://webkit.org/coding/contributing.html

Also, I think that the "abort()" definition should go in config.h or some
header which config.h (or whatever pre-compiled header your WinCE build uses). 
 It's silly to need to have #ifdefs around every abort() usage.  Another way
would be to change all abort usages to some webkit-specific function (like
ABORT()) or similar, but I think it's better to just define abort() for WinCE.


More information about the webkit-reviews mailing list