[webkit-reviews] review requested: [Bug 20953] Rework the Font handling in QtWebKit : [Attachment 23593] Add compiletime option to not use the fast path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 20 13:33:07 PDT 2008


Eric Seidel <eric at webkit.org> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 20953: Rework the Font handling in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=20953

Attachment 23593: Add compiletime option to not use the fast path
https://bugs.webkit.org/attachment.cgi?id=23593&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough to me.  Normally we don't use "return foo()" in functions
returning void.

The WTF_USE definition should really go in WebCore/config.h (unless you all
don't use that).


More information about the webkit-reviews mailing list