[webkit-reviews] review granted: [Bug 20950] Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc : [Attachment 23608] Fix an off-by-one error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 20 13:17:24 PDT 2008
Eric Seidel <eric at webkit.org> has granted mitz at webkit.org's request for review:
Bug 20950: Reproducible assertion failure running svg/custom/acid3-test-77.html
multiple times under guard malloc
https://bugs.webkit.org/show_bug.cgi?id=20950
Attachment 23608: Fix an off-by-one error
https://bugs.webkit.org/attachment.cgi?id=23608&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems this should be pulled out into a nicely named local variable, possibly
with a comment explaining why it does not include the first char (or maybe
that's obvious from the code).
int remainingCharsInRun = end - it;
or similar. I would like to see a local variable used when you land, but I
don't need to see the patch again.
More information about the webkit-reviews
mailing list