[webkit-reviews] review denied: [Bug 20949] Catch repeated messages in Inspector Controller to limit memory usage : [Attachment 23586] patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 20949: Catch repeated messages in Inspector Controller to limit memory
usage
https://bugs.webkit.org/show_bug.cgi?id=20949

Attachment 23586: patch
https://bugs.webkit.org/attachment.cgi?id=23586&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
static ConsoleMessage* previousMessage = 0;

Is unsafe as it is global whereas InspectorController is per WebView (afaiaa)
so you could have to webviews spewing the same error and you would get
excitingly confused.

I'm also not sure what happens if i had a case where i had a repeating group of
messages -- say trying to load malformed content or some such could lead to
repeating groups of messages, but because it's not the same message over and
over in immediate succession it would not be caught.