[webkit-reviews] review requested: [Bug 20945] REGRESSION (r36628): Safari icon on error page is squished : [Attachment 23582] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 19 14:50:25 PDT 2008

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 20945: REGRESSION (r36628): Safari icon on error page is squished

Attachment 23582: patch v1

------- Additional Comments from Peter Kasting <pkasting at google.com>
I can't test that this actually fixes the bug, but I bet it will; please try it

The attempted fix here is to be more careful about getting/setting
m_repetitionCount, similar to how we already do with other members that mirror
members on m_source.  Don't check it unless it's actually set.

I eliminated m_animatingImageType, since it was just equivalent to
(m_repetitionCount == cAnimationNone) and thus unnecessary.

Instead of a simple bool m_haveRepetitionCount like the rest of the members on
this class do I had to use a tristate enum m_repetitionCountStatus, to handle
the way we recheck the repetition count at the end of decoding the image.

More information about the webkit-reviews mailing list