[webkit-reviews] review denied: [Bug 20887] Legend tag should be exposed through AX : [Attachment 23548] Expose <legend> tag in AX

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 18 23:30:25 PDT 2008

Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 20887: Legend tag should be exposed through AX

Attachment 23548: Expose <legend> tag in AX

------- Additional Comments from Darin Adler <darin at apple.com>
 427	 Node *element = m_renderer->element();

Should be Node*, not "Node *".

 1061	  if (isFieldset())
 1062	      return

This assumes that the renderer will be a RenderFieldset because the tag is
fieldsetTag. Why is that a safe assumption? Instead, both function should be
looking at hte renderer, and neither should be asking what the tag name is.

Patch otherwise looks fine. review- because of the DOM/Renderer assumption.

More information about the webkit-reviews mailing list