[webkit-reviews] review granted: [Bug 17772] Inspector should support point-and-click to select a node to inspect : [Attachment 23549] round 2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Matt Lilek (pewtermoose)
<webkit at mattlilek.com>'s request for review:
Bug 17772: Inspector should support point-and-click to select a node to inspect
https://bugs.webkit.org/show_bug.cgi?id=17772

Attachment 23549: round 2
https://bugs.webkit.org/attachment.cgi?id=23549&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+    InspectorController* inspector = m_page->inspectorController();
+    if (!inspector)
+	 return;
+    inspector->mouseDidMoveOverElement(result, modifierFlags);


Better written as:

if (InspectorController* inspector = m_page->inspectorController())
       inspector->mouseDidMoveOverElement(result, modifierFlags);

+    InspectorController* controller =
reinterpret_cast<InspectorController*>(JSObjectGetPrivate(thisObject));
+    if (controller)
+	 controller->toggleSearchForNodeInPage();

Better written as:

if (InspectorController* controller =
reinterpret_cast<InspectorController*>(JSObjectGetPrivate(thisObject)))
      controller->toggleSearchForNodeInPage();