[webkit-reviews] review granted: [Bug 20908] TransformOperations should not inherit from Vector : [Attachment 23541] Patch to fix bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 18 15:41:02 PDT 2008


Sam Weinig <sam at webkit.org> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 20908: TransformOperations should not inherit from Vector
https://bugs.webkit.org/show_bug.cgi?id=20908

Attachment 23541: Patch to fix bug
https://bugs.webkit.org/attachment.cgi?id=23541&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+    Animation* animation(size_t i) { return m_animations[i].get(); }
+    const Animation* animation(size_t i) const { return m_animations[i].get();
}
It seems like using operator[] here would be cleaner.

r=me


More information about the webkit-reviews mailing list