[webkit-reviews] review granted: [Bug 20515] Crash upon parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-dashboard-region= : [Attachment 23539] Patch 2

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 20515: Crash upon parsing CSS: unicode-range:
searchfield-cancel-buttonpt=-webkit-dashboard-region=
https://bugs.webkit.org/show_bug.cgi?id=20515

Attachment 23539: Patch 2
https://bugs.webkit.org/attachment.cgi?id=23539&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
+	 case CSS_PARSER_IDENTIFIER:
+	     text = quoteStringIfNeeded(m_value.string);

Add a "break;" in case we add more cases in the future.

This line is wrong:

+	     value.unit = m_type;

It should set the type to CSS_IDENT.

Please put the layout test under fast/css/variables, since when we turn CSS
variables off, we don't want to have to look for tests in other subdirectories.


Fix those two things and r=me