[webkit-reviews] review cancelled: [Bug 16401] [GTK] GObject/C DOM binding : [Attachment 23508] massively (oversimplified, unfortunately) reduced patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 18 13:42:48 PDT 2008

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has cancelled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 16401: [GTK] GObject/C DOM binding

Attachment 23508: massively (oversimplified, unfortunately) reduced patch

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
removed, as requested, #ifdef'd code.
the #ifdef'd code and the associated comments is a reminder to
put in absolutely critical and essential functionality.
the removal of this #ifdef'd code has been replaced with a
description outlining exactly why the functionality which has
not been completed is utterly essential for correct operation
of the bindings code.

this replacement patch is functionally useless, providing nothing
but "Node".  there is no way to test it (through the gtk webkit port)
because there is no "link" in to the webkit_web_*() gtk bindings.

this replacement patch is provided, as requested, on the basis
that it will make it easier to assess the code in stages.

More information about the webkit-reviews mailing list