[webkit-reviews] review requested: [Bug 16401] [GTK] GObject/C DOM binding : [Attachment 23508] massively (oversimplified, unfortunately) reduced patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 14:28:05 PDT 2008

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 16401: [GTK] GObject/C DOM binding

Attachment 23508: massively (oversimplified, unfortunately) reduced patch

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
ok - after talking to mark, given that the target
functionality requires a 250k patch, here is a
_reduced_ patch (80k) which provides no actual useable
functionality but provides "a start".

the only functionality added is "Node" - GdomNode.

to ensure that memory corruption, memory leaks, lost
ptrRefs and thus segfaults do not occur, GdomDOMObject -
and the methodology copied directly almost word-for-word
cut-and-paste from JSBindings.cpp into GDOMBindings.cpp
is absolutely essential, and cannot be "cut".

More information about the webkit-reviews mailing list