[webkit-reviews] review cancelled: [Bug 20690] Support for DNS prefetch : [Attachment 23479] Updated patch with improved layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 11:08:59 PDT 2008

Collin Jackson <collinj at webkit.org> has cancelled Collin Jackson
<collinj at webkit.org>'s request for review:
Bug 20690: Support for DNS prefetch

Attachment 23479: Updated patch with improved layout test

------- Additional Comments from Collin Jackson <collinj at webkit.org>
(In reply to comment #8)
> I don't think it is good to have two callbacks that do essentially the same
> thing. Also didParseAnchor() tells nothing about what should be implemented
> there where as prefetchDNS() is a good name.

Ok, I got rid of didParseAnchor.

> I think relative link URLs (or actually anything that does not start with
> http:// or https://) can be ignored since the domain is the same as the
> document's. That would help cutting out many links on many pages. 

Ok, I've implemented this suggestion. I also added a check for scheme-relative
URLs (starting with "//"), since they are used heavily on certain sites (e.g.

More information about the webkit-reviews mailing list