[webkit-reviews] review denied: [Bug 20890] Need to decouple building for the Mac from using NSURL/CFURL : [Attachment 23482] Proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 20890: Need to decouple building for the Mac from using NSURL/CFURL
https://bugs.webkit.org/show_bug.cgi?id=20890

Attachment 23482: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=23482&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This will need a ChangeLog, and to be marked for review to be a real patch
considered for landing.  See:
http://webkit.org/coding/contributing.html

Mark suggests that we add a define USE(NSURLRESPONSE) to wrap these, and make
the MAC build define WTF_USE_NSURLRESPONSE and the CHROMIUM build make sure
that define is off.

I'm not even sure why these methods exist, since somehow the non-mac builds
don't need these on the clients.

The file you would need to edit to add such a USE would be:
http://trac.webkit.org/browser/trunk/WebCore/config.h