[webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 23484] Improved possible fix to bug 20534
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 16 13:14:32 PDT 2008
Glenn Wilson <gwilson at google.com> has asked for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534
Attachment 23484: Improved possible fix to bug 20534
https://bugs.webkit.org/attachment.cgi?id=23484&action=edit
------- Additional Comments from Glenn Wilson <gwilson at google.com>
I've modified this patch to have overridePreference and resetToDefaults in
WebPreferencesPrivate instead of WebPreferences.
re: testing...I thought it was a neat quirk of the patch, but now I can see
that using it would probably be unwise, since all tests should be able to be
run independently.
Thanks for the review & the feedback!
More information about the webkit-reviews
mailing list