[webkit-reviews] review requested: [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity : [Attachment 23471] Deprecate String::format()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 16 07:18:07 PDT 2008

Alp Toker <alp at nuanti.com> has asked  for review:
Bug 18994: LANG/LC_ALL influences the result of element.style.opacity

Attachment 23471: Deprecate String::format()

------- Additional Comments from Alp Toker <alp at nuanti.com>
	Use UString::from() instead of String::format() in String::number()
	functions where possible.

	Start to replace uses of String::format() in WebCore with
	StringBuilder and direct concatenation.

	As a side-effect, several incorrect or needless string conversions
	that were done by String::format() callers are now avoided.

	String::format() should not be used in new code.

Note: These changes need to be checked for regressions with the Mac layout
tests before going in.

More information about the webkit-reviews mailing list