[webkit-reviews] review denied: [Bug 17719] Qt, Cairo and wx require toDataURL implementations : [Attachment 23464] toDataURL implementation in Cairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 16 00:36:02 PDT 2008

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 17719: Qt, Cairo and wx require toDataURL implementations

Attachment 23464: toDataURL implementation in Cairo

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me.

static cairo_status_t writeFunction(void *closure, const unsigned char *data,
unsigned int length)
98102 {
99	notImplemented();
100	 return String();
 103	 Vector<char> *in = (Vector<char> *) closure;
 104	 in->append(data, length);
 106 }

Has style issues.  * placement, and the c-style cast (Vector<char> *) should be
a reinterpret_cast<Vector<char>*> instead.  Unfortunately you don't yet have
commit-bit :( so I'll ask you to post another patch (which I don't need to see,
but is needed for someone else to land).

More information about the webkit-reviews mailing list