[webkit-reviews] review granted: [Bug 20875] DRT crashes on animation tests : [Attachment 23458] Step 1: rename layoutTestController to gLayoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 16 00:20:17 PDT 2008


Eric Seidel <eric at webkit.org> has granted Simon Fraser
<simon.fraser at apple.com>'s request for review:
Bug 20875: DRT crashes on animation tests
https://bugs.webkit.org/show_bug.cgi?id=20875

Attachment 23458: Step 1: rename layoutTestController to gLayoutTestController
https://bugs.webkit.org/attachment.cgi?id=23458&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm OK with this change, but I'd really like to see the style guide updated at
the same time if "g" is the new prefix for static variables.

http://webkit.org/coding/coding-style.html

Please update the style guide when landing this change, or make sure we have a
style guide for this type of variable.	Right now we have no words on the
subject in the guide.

Also, this needs a ChangeLog.


More information about the webkit-reviews mailing list