[webkit-reviews] review requested: [Bug 20875] DRT crashes on animation tests : [Attachment 23459] Step 2: bug fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 21:58:01 PDT 2008

Simon Fraser <simon.fraser at apple.com> has asked  for review:
Bug 20875: DRT crashes on animation tests

Attachment 23459: Step 2: bug fix.

------- Additional Comments from Simon Fraser <simon.fraser at apple.com>
The crash was caused by LayoutTestController::notifyDone() getting called after
the LayoutTestController had been deleted, so the setting of m_waitToDump was
writing to random memory.

I fixed this by having the LayoutTestController keep a pointer to the
JSObjectRef that refers to it, and nulling out the privateData when the
LayoutTestController is deleted. I also added a finalize function for the
JSObjectRef, to clear out the JSObjectRef on the LayoutTestController.

If a test tries to call notifyDone() twice now, then DRT will spew to stdout
and stderr.

More information about the webkit-reviews mailing list