[webkit-reviews] review requested: [Bug 17772] Inspector should support point-and-click to select a node to inspect : [Attachment 23456] Initial cut
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 15 19:23:32 PDT 2008
Matt Lilek (pewtermoose) <webkit at mattlilek.com> has asked for review:
Bug 17772: Inspector should support point-and-click to select a node to inspect
https://bugs.webkit.org/show_bug.cgi?id=17772
Attachment 23456: Initial cut
https://bugs.webkit.org/attachment.cgi?id=23456&action=edit
------- Additional Comments from Matt Lilek (pewtermoose)
<webkit at mattlilek.com>
As I wrote in the ChangeLog:
Despite putting this up for review, I'm not intending to land it as is. Among
the known issues:
- Need better art for the magnifying glass button
- Is EventHandler really the best place for intercepting the node click
- feels dirty. Would
making -[WebView setHoverFeedbackSuspended:] cross-platform be a
better route?
- I think I can get away with not having to track searchingForNode in
ElementsPanel
- Some method names could be tweaked.
More information about the webkit-reviews
mailing list