[webkit-reviews] review granted: [Bug 20865] Kill JSSVGLazyEventListener and cleanup event handling : [Attachment 23450] Initial patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 20865: Kill JSSVGLazyEventListener and cleanup event handling
https://bugs.webkit.org/show_bug.cgi?id=20865

Attachment 23450: Initial patch
https://bugs.webkit.org/attachment.cgi?id=23450&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not really sure ForType and ForTypeAndAtrribute are really worth the extra
characters.  I think they're probably just as clear w/o the extra typing.

I think it's strange that a bool flips between "attached to a node" and
"attached to the window".  That could also be a 2-value enum (and might be
clearer that way).

Seems fine.  Certainly better than what we have today.	We'll probably go
through another round of cleanup yet.