[webkit-reviews] review granted: [Bug 20865] Kill JSSVGLazyEventListener and cleanup event handling : [Attachment 23450] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 16:46:44 PDT 2008

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 20865: Kill JSSVGLazyEventListener and cleanup event handling

Attachment 23450: Initial patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not really sure ForType and ForTypeAndAtrribute are really worth the extra
characters.  I think they're probably just as clear w/o the extra typing.

I think it's strange that a bool flips between "attached to a node" and
"attached to the window".  That could also be a 2-value enum (and might be
clearer that way).

Seems fine.  Certainly better than what we have today.	We'll probably go
through another round of cleanup yet.

More information about the webkit-reviews mailing list