[webkit-reviews] review granted: [Bug 20862] Inline code generation of eq_null/neq_null for CTI. : [Attachment 23448] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 15:40:34 PDT 2008

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 20862: Inline code generation of eq_null/neq_null for CTI.

Attachment 23448: The patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me, but i give a stern parental was of the index finger at this vptr abuse --
we need to get off of it!

Also, please add a comment in JSObject.h by the declaration of
JSObject::masqueradesAsUndefined that basically says, "You can't usefully
override this virtual function without hand-coding some assembly in CTI.cpp"

More information about the webkit-reviews mailing list