[webkit-reviews] review granted: [Bug 20435] Canvas missing exceptioncode for gradients : [Attachment 23390] Canvas Gradients exception

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 15:12:14 PDT 2008

Eric Seidel <eric at webkit.org> has granted Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20435: Canvas missing exceptioncode for gradients

Attachment 23390: Canvas Gradients exception

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine.  It would be best if you could add a couple positive tests as
well (to make sure that your exceptions aren't thrown too often, or that future
added code doesn't make the exceptions thrown too often.

More information about the webkit-reviews mailing list