[webkit-reviews] review requested: [Bug 20664] [GTK] File names are not always encodable in UTF-8 : [Attachment 23441] Add filenameToString and filenameFromString to FileSystemGtk.cpp

[bugzilla-daemon at webkit.org]

Marco Barisione <marco.barisione at collabora.co.uk> has asked  for review:
Bug 20664: [GTK] File names are not always encodable in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=20664

Attachment 23441: Add filenameToString and filenameFromString to
FileSystemGtk.cpp
https://bugs.webkit.org/attachment.cgi?id=23441&action=edit

------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
(In reply to comment #7)
> +#if PLATFORM(WIN)
> 
> should be WIN_OS.

Fixed.

> g_uri_escape_string()
> 
> ^ only available in GLib >= 2.16

I included a copy of that function so we can use with glib < 2.16. Is it the
right way to do that?
 
> For this change to make sense, we need to decide exactly what we expect the
> developer to pass to user-stylesheet-uri: a local filename (byte array) or a
> well formatted URI?

WebCore expects a URI and considering the name I think that it should be clear
that it's a URI and not a filename.