[webkit-reviews] review granted: [Bug 20821] Cache property transitions to speed up object initialization : [Attachment 23406] Fully implemented transition cache, now with a bonus feature: correctness

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 14 01:08:12 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821

Attachment 23406: Fully implemented transition cache, now with a bonus feature:
correctness
https://bugs.webkit.org/attachment.cgi?id=23406&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
I think "failuresCases" would probably be better as "failureCases".

You have some extra blank lines, like CTI.cpp:1900 and Machine.cpp:2474.

Perhaps sIDC would be better as structureIDChain or chain? What do you think?

Other than that, r=me.


More information about the webkit-reviews mailing list