[webkit-reviews] review granted: [Bug 20830] [GTK] Don't use deprecated pango API : [Attachment 23399] Updated patch with PANGO_VERSION_CHECK guards

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 13 22:13:16 PDT 2008


Alp Toker <alp at nuanti.com> has granted Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 20830: [GTK] Don't use deprecated pango API
https://bugs.webkit.org/show_bug.cgi?id=20830

Attachment 23399: Updated patch with PANGO_VERSION_CHECK guards
https://bugs.webkit.org/attachment.cgi?id=23399&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
Our convention with version check macros is to put the success case first for
consistency. Please update the patch or fix when landing, r=me otherwise


More information about the webkit-reviews mailing list