[webkit-reviews] review denied: [Bug 20777] [CURL] memory leak of ResouceHandles : [Attachment 23343] Fix the leak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 12 12:26:58 PDT 2008


Eric Seidel <eric at webkit.org> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 20777: [CURL] memory leak of ResouceHandles
https://bugs.webkit.org/show_bug.cgi?id=20777

Attachment 23343: Fix the leak
https://bugs.webkit.org/attachment.cgi?id=23343&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I hate this kind of memory management.	(Nothing personal).  Could we change
this API so that it either used ref-counting, or didn't have this kind of
single-ownership memory model burried inside these functions which are named
"remove" and not "destroy".  Why is it clear that passing something for removal
should destroy it!?


More information about the webkit-reviews mailing list