[webkit-reviews] review denied: [Bug 20435] Canvas missing exceptioncode for gradients : [Attachment 23197] Canvas Gradients exception

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 12 12:13:42 PDT 2008


Eric Seidel <eric at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20435: Canvas missing exceptioncode for gradients
https://bugs.webkit.org/show_bug.cgi?id=20435

Attachment 23197: Canvas Gradients exception
https://bugs.webkit.org/attachment.cgi?id=23197&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine, but it *really* should use the new js test system.  see
LayoutTests/fast/js for examples.

Then things like:

+	 try{
+	     var gradient = ctx.createLinearGradient(0, 0, 100, -Infinity);
+	     print("FAIL");
+	 } catch (e) {
+	     print("PASS: a -Infinity value for y1, got exception as
expected");
+	 }

turn into:
shouldThrow("ctx.createLinearGradient(0, 0, 100, -Infinity)")

You could even re-write this as a loop if you really wanted to, which built up
different arg arrays.


More information about the webkit-reviews mailing list