[webkit-reviews] review denied: [Bug 20729] [Qt] Canvas gradients don't work as expected : [Attachment 23314] Qt gradients
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 10 12:52:12 PDT 2008
Simon Hausmann <hausmann at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s
request for review:
Bug 20729: [Qt] Canvas gradients don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=20729
Attachment 23314: Qt gradients
https://bugs.webkit.org/attachment.cgi?id=23314&action=edit
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Looks good, but there's a small coding style nitpick:
If (qFuzzyCompare(...)) {
one line of code
} else
another line of code
There's no need for braces in one-liners
More information about the webkit-reviews
mailing list