[webkit-reviews] review granted: [Bug 20741] REGRESSION: ISO-8859-8-I encoding is registered incorrectly : [Attachment 23318] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 10 07:41:11 PDT 2008


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 20741: REGRESSION: ISO-8859-8-I encoding is registered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=20741

Attachment 23318: proposed fix
https://bugs.webkit.org/attachment.cgi?id=23318&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> && strcasecmp(atomicName, "iso-8859-8") == 0)

I generally try to avoid POSIX functions that ignore case, since they are
sensitive to the POSIX locale setting. Instead we make ASCII variants of those
functions. Hence we use our own ASCIICType.h rather than ctype.h, etc. In this
case, we're probably OK, but I'd rather see this follow that pattern.

> This was not an issue on the Mac, as
> we also support these via TEC (which we should stop doing)

I agree! I only included those in the TEC list because I thought ICU did not
support them! Is there no downside to using the MIME names?

r=me


More information about the webkit-reviews mailing list