[webkit-reviews] review granted: [Bug 20679] Need to handle the case when 0% or 100% keyframe is omitted : [Attachment 23207] Patch, including LayoutTest file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 15:40:59 PDT 2008


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 20679: Need to handle the case when 0% or 100% keyframe is omitted
https://bugs.webkit.org/show_bug.cgi?id=20679

Attachment 23207: Patch, including LayoutTest file
https://bugs.webkit.org/attachment.cgi?id=23207&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+    if (rule->item(0)->key() != 0 || rule->item(rule->length()-1)->key() != 1)


We usually write rule->item(0)->key() != 0 as just rule->item(0)->key().   You
need spaces (rule->length()-1) here between length() and 1.

r=me


More information about the webkit-reviews mailing list