[webkit-reviews] review granted: [Bug 20699] SVGPaintServer CleanUp : [Attachment 23228] SVGPaintServer cleanUp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 09:56:21 PDT 2008

Eric Seidel <eric at webkit.org> has granted Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20699: SVGPaintServer CleanUp

Attachment 23228: SVGPaintServer cleanUp

------- Additional Comments from Eric Seidel <eric at webkit.org>
We should really fix dashes.  (Instead of adding an #ifdef).  Just add a
GraphicsContext::setLineDash(DashArray) function to GraphicContext, and an:
OwnPtr<DashArray> onto the GraphicsContext state, and then copy the passed in
DashArray onto the state any time the method is called.  We'd have to fix
stroke* to setup the dash calls per-platform, but I think that's teh better
long term solution.  I guess that can be a separate patch.

Does this still work for CG?  If so, then r+

More information about the webkit-reviews mailing list