[webkit-reviews] review granted: [Bug 17537] Try MIME before trying IANA names when enumerating ICU converters : [Attachment 23270] patch updated with more detailed ChangeLog and strcasecmp added

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jungshik.shin at gmail.com>'s request for review:
Bug 17537: Try MIME before trying IANA names when enumerating ICU converters
https://bugs.webkit.org/show_bug.cgi?id=17537

Attachment 23270: patch updated with more detailed ChangeLog and strcasecmp
added
https://bugs.webkit.org/attachment.cgi?id=23270&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

+	 // And so on. Some versions of ICU may have this in lowercase while
others have
+	 // in uppercase. Need to confirm. If it's one way or the other, we can
just
+	 // use strcmp.

I've confirmed that this is different between Tiger and Leopard versions of
ICU, and will re-word the comment when landing. I'll also tweak ChangeLog
entries a little.

Thanks for fixing this!