[webkit-reviews] review denied: [Bug 20409] Command line API unavailable when paused in the debugger : [Attachment 23226] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 7 08:31:14 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 20409: Command line API unavailable when paused in the debugger

Attachment 23226: proposed patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch is the right approach, but it will break printing of local
variables. ANy local variables that shadow a window property, like document or
alert, etc. will always print the window version and not the local version.

We can't use the with statement when paused. So I am not sure how to fix this
in JS alone. We might need to modify evaluateInSelectedCallFrame to take an
object that it adds to the bottom of the scope chain, so local variables are
found first.

More information about the webkit-reviews mailing list