[webkit-reviews] review cancelled: [Bug 17537] Try MIME before trying IANA names when enumerating ICU converters : [Attachment 23216] patch updated (with typo fixed)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 6 12:51:09 PDT 2008
Jungshik Shin <jungshik.shin at gmail.com> has cancelled Jungshik Shin
<jungshik.shin at gmail.com>'s request for review:
Bug 17537: Try MIME before trying IANA names when enumerating ICU converters
https://bugs.webkit.org/show_bug.cgi?id=17537
Attachment 23216: patch updated (with typo fixed)
https://bugs.webkit.org/attachment.cgi?id=23216&action=edit
------- Additional Comments from Jungshik Shin <jungshik.shin at gmail.com>
On my Mac OS 10.4, somehow, the MIME name for ISO-8859-9 came out in lowercase,
which led to the failure of fast/text/encoding/char-decoding.html.
I checked the revision history of ICU's convrtrs.txt and couldn't find any
trace of that being in lowercase in the past. Anyway, to be safe, I changed
the patch to check for both ISO-8859-9 and iso-8859-9 . (I didn't use
strcasecmp or stricmp because neither is portable).
More information about the webkit-reviews
mailing list