[webkit-reviews] review granted: [Bug 20670] Need more USE(JSC) wrappers to build Chromium from ToT WebKit : [Attachment 23201] patch, will add changelog before landing

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20670: Need more USE(JSC) wrappers to build Chromium from ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=20670

Attachment 23201: patch, will add changelog before landing
https://bugs.webkit.org/attachment.cgi?id=23201&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The Image.h, FileSystem.h, RenderStyle.h, and CompositeAnimation.h changes
seems to be unrelated.

+#if USE(JSC)
     PassRefPtr<Element> querySelector(const String& selectors, NSResolver*,
ExceptionCode&, KJS::ExecState*);
     PassRefPtr<NodeList> querySelectorAll(const String& selectors,
NSResolver*, ExceptionCode&, KJS::ExecState*);
+#endif

This ifdef is backwards. In my opinion we're leaving this out when using V8
because V8 doesn't have it implemented, so it should be #if !USE(V8).

But despite these quibbles I guess it's OK to land as-is.