[webkit-reviews] review granted: [Bug 20435] Canvas missing exceptioncode for gradients : [Attachment 23140] Canvas gradients exceptions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 5 09:57:33 PDT 2008


Sam Weinig <sam at webkit.org> has granted Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20435: Canvas missing exceptioncode for gradients
https://bugs.webkit.org/show_bug.cgi?id=20435

Attachment 23140: Canvas gradients exceptions
https://bugs.webkit.org/attachment.cgi?id=23140&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+    if (!isfinite(value) || value < 0. || value > 1.) {
Please use 0 and 1.0f here.

r=me


More information about the webkit-reviews mailing list