[webkit-reviews] review requested: [Bug 15643] Double-clicking word should select whitespace after the word : [Attachment 23176] Improved possible fix to bug 15643

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 4 13:39:39 PDT 2008


Glenn Wilson <wilsong at gmail.com> has asked  for review:
Bug 15643: Double-clicking word should select whitespace after the word
https://bugs.webkit.org/show_bug.cgi?id=15643

Attachment 23176: Improved possible fix to bug 15643
https://bugs.webkit.org/attachment.cgi?id=23176&action=edit

------- Additional Comments from Glenn Wilson <wilsong at gmail.com>
Ok, here is an improved possible fix.

First, I added a method in Selection that will add trailing whitespace.  I
wanted to keep things simple with a while loop, rather than use a
TextBreakIterator.

This method will only be called by
EventHandler::selectClosestWordFromMouseEvent  if on a Windows system, and the
event was a mouse double-click.

I wasn't exactly sure how to check for smart editing, but it would be easy to
add it to EventHandler's checks if necessary.


More information about the webkit-reviews mailing list