[webkit-reviews] review denied: [Bug 15643] Double-clicking word should select whitespace after the word : [Attachment 23130] Possible fix to issue 15643
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 2 17:02:01 PDT 2008
mitz at webkit.org has denied Glenn Wilson <wilsong at gmail.com>'s request for
review:
Bug 15643: Double-clicking word should select whitespace after the word
https://bugs.webkit.org/show_bug.cgi?id=15643
Attachment 23130: Possible fix to issue 15643
https://bugs.webkit.org/attachment.cgi?id=23130&action=edit
------- Additional Comments from mitz at webkit.org
+#include <unicode/ubrk.h>
ICU is not available on all platforms, and should not be used directly like
that. You can use a TextBreakIterator.
+#if PLATFORM(WIN_OS)
I do not think this is the appropriate test, as the new behavior is not
necessarily desirable for Safari on windows.
Finally, I don't see how this change is specific to selections created with
double-click. It seems like it would affect any other selection.
Selection::validate() is not the right place to introduce this change.
More information about the webkit-reviews
mailing list